Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Add content/ja/docs/demo/collector-data-flow-dashboard/index.md #6353

Merged
merged 4 commits into from
Mar 3, 2025
Merged

[ja] Add content/ja/docs/demo/collector-data-flow-dashboard/index.md #6353

merged 4 commits into from
Mar 3, 2025

Conversation

tk3fftk
Copy link
Contributor

@tk3fftk tk3fftk commented Feb 16, 2025

This pull request adds a new documentation page in Japanese to the content/ja/docs/demo/collector-data-flow-dashboard/index.md file.

This file is corresponding to https://opentelemetry.io/ja/docs/demo/collector-data-flow-dashboard/

  • Added a new page titled "コレクターデータフローダッシュボード" to the Japanese documentation.

@tk3fftk tk3fftk requested a review from a team as a code owner February 16, 2025 10:59
@opentelemetrybot opentelemetrybot requested review from a team February 16, 2025 10:59
tk3fftk
tk3fftk commented Feb 16, 2025
View reviewed changes
content/ja/docs/demo/collector-data-flow-dashboard/index.md Outdated

![OpenTelemetry Collector Data Flow Overview](otelcol-data-flow-overview.png)

## 入力と出力のメトリクス
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ingress/Egress を単純に入力と出力にしていますが、迷ったポイントだったので確認お願いします 🙇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

悩ましいですね。input/outputとは別の意味を含んでいるので、ネットワーク用語としてのイングレス、エグレスでも良い気がします。（Kubernetesのおかげでこの用語もだいぶ浸透している気がしています）

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！

input/outputとは別の意味を含んでいる

こちら同意です！ イングレス、エグレスに修正しました 🙇

7a400f4

@tk3fftk tk3fftk force-pushed the ja/docs/demo/collector-data-flow-dashboard branch from 98c0191 to 5b0fa88 Compare February 16, 2025 11:03
@tk3fftk tk3fftk changed the title [ja] Add OpenTelemetry Collector Data Flow Dashboard documentation [ja] Add content/ja/docs/demo/collector-data-flow-dashboard/index.md Feb 16, 2025
ymotongpoo
ymotongpoo reviewed Feb 19, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I left some comments and I'd like to confirm your thoughts on those.

content/ja/docs/demo/collector-data-flow-dashboard/index.md Outdated

![OpenTelemetry Collector Data Flow Overview](otelcol-data-flow-overview.png)

## 入力と出力のメトリクス
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

悩ましいですね。input/outputとは別の意味を含んでいるので、ネットワーク用語としてのイングレス、エグレスでも良い気がします。（Kubernetesのおかげでこの用語もだいぶ浸透している気がしています）

content/ja/docs/demo/collector-data-flow-dashboard/index.md Outdated

OpenTelemetryコレクターを通じてデータフローを監視することは、いくつかの重要な理由があります。サンプル数やカーディナリティなど、入力されるデータのマクロレベルの視点を得ることは、コレクターの内部動作を理解する上で不可欠です。しかし、詳細に踏み込むと、相互接続が複雑になる可能性があります。コレクターデータフローダッシュボードは、OpenTelemetryデモアプリケーションの機能を示すことを目的としており、ユーザーが構築するための基盤を提供します。

コレクターデータフローダッシュボードは、監視すべきメトリクスについて重要なガイダンスを提供します。ユーザーは、memory_delimiterプロセッサーやその他のデータフロー指標など、自身のユースケースに合わせた必要なメトリクスを追加することで、独自のダッシュボードバリエーションを作成できます。デモダッシュボードは出発点として機能し、ユーザーが多様な利用シナリオを探索し、独自の監視ニーズに合わせてツールを適応させることを可能にします。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここの「バリエーション」は冗長なので、大意も変わらないですし落としてしまうのはどうでしょうか。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確かに、落としました！
034751e

@ymotongpoo ymotongpoo force-pushed the ja/docs/demo/collector-data-flow-dashboard branch from 5b0fa88 to 568e296 Compare February 19, 2025 06:53
@opentelemetrybot opentelemetrybot requested a review from a team February 19, 2025 06:53
@tk3fftk tk3fftk requested a review from ymotongpoo February 19, 2025 14:01
@ymotongpoo ymotongpoo force-pushed the ja/docs/demo/collector-data-flow-dashboard branch from 7a400f4 to 7e933ba Compare February 26, 2025 05:17
ymotongpoo
ymotongpoo approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 26, 2025
chalin
chalin reviewed Feb 26, 2025
View reviewed changes
content/ja/docs/demo/collector-data-flow-dashboard/index.md Outdated

コレクターデータフローダッシュボードは、監視すべきメトリクスについて重要なガイダンスを提供します。ユーザーは、memory_delimiterプロセッサーやその他のデータフロー指標など、自身のユースケースに合わせた必要なメトリクスを追加することで、独自のダッシュボードを作成できます。デモダッシュボードは出発点として機能し、ユーザーが多様な利用シナリオを探索し、独自の監視ニーズに合わせてツールを適応させることを可能にします。

## データフローの概要
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add heading IDs in this page as described in https://opentelemetry.io/docs/contributing/localization/#headings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo - I've removed the docs-approval-missing label. Please add it back when this PR is once again ready for review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the change. Thanks for caching this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for caching and pushing this 🙇

@chalin chalin removed the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Feb 26, 2025
@ymotongpoo ymotongpoo force-pushed the ja/docs/demo/collector-data-flow-dashboard branch from 7e933ba to e027635 Compare February 26, 2025 08:55
@opentelemetrybot opentelemetrybot requested review from a team February 26, 2025 08:56
@ymotongpoo
Update index.md
f07eae3 
add headings ID
ymotongpoo
ymotongpoo approved these changes Mar 2, 2025
View reviewed changes
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymotongpoo ymotongpoo added the docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer label Mar 2, 2025
@chalin chalin added this pull request to the merge queue Mar 3, 2025
Merged via the queue into open-telemetry:main with commit 164ff05 Mar 3, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@tk3fftk tk3fftk deleted the ja/docs/demo/collector-data-flow-dashboard branch March 4, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymotongpoo ymotongpoo ymotongpoo approved these changes

@chalin chalin chalin approved these changes

Assignees
No one assigned
Labels
docs-approval-missing Co-owning SIG has provided approval, PR needs approval from docs maintainer lang:ja
Projects
SIG Comms: Docs Translation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tk3fftk @opentelemetrybot @ymotongpoo @chalin